Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn berry #241

Closed
wants to merge 8 commits into from
Closed

Yarn berry #241

wants to merge 8 commits into from

Conversation

mehallhm
Copy link
Contributor

@mehallhm mehallhm commented Nov 13, 2024 •
edited
Loading

Purpose

Migrates off of the end-of-life Yarn Classic to the actively maintained Yarn Berry version. In general, it is a drop in replacement, using the Node experimental Corepack as the preferred installation / management tool (the irony of managing a package manager).

Tickets

Closes #225, Closes #232

Feature List

  • Switches from Yarn Classic to Yarn Berry in node_modules compatibility mode.
  • Updates the Dockerfile to enable Corepack and use the same version of Yarn as dev, ensuring consistency.
  • Prepped Dockerfile for a better build system in the future. Yarn Berry forces us to stop abusing Yarn like we were before so some of this needed to happen now anyway. This will be something that will show its value soon...
  • Updates the GH actions to use Corepack to install deps (and generally get them to newer versions).

Notes

I will open a PR on searchneu soon to ensure that there is a version locked in because Corepack likes to add itself otherwise.

Reviewers

Primary:
@ananyaspatil

Secondary:
@Anzhuo-W @nickpfeiffer05 @cherman23

@mehallhm
upgrade to Yarn Berry
9a950c9
@mehallhm
Update Dockerfile and prod build command
b2e0b49 
Update the Dockerfile to use Yarn Berry and Corepack, changing the
build commands to reflect this change.
@mehallhm mehallhm self-assigned this Nov 13, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 13, 2024 •
edited
Loading

Coverage Status

coverage: 80.173%. remained the same
when pulling 3adf0c3 on yarn-berry
into a5d14a0 on master.

@mehallhm
Copy link
Contributor Author

I'm really not liking these request unit tests... They are super finicky both in CI and locally. I can barely curl these URLs! Something we should improve....

@mehallhm mehallhm marked this pull request as ready for review November 13, 2024 19:31
@mehallhm mehallhm mentioned this pull request Nov 19, 2024
Closed
@mehallhm mehallhm mentioned this pull request Jan 21, 2025
Merged
@mehallhm
Copy link
Contributor Author

This PR has been merged into #244 to fix a Dependency issue preventing the CI from running

@mehallhm mehallhm closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mehallhm mehallhm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade all GitHub actions Upgrade to Yarn Berry
2 participants
@mehallhm @coveralls